cloud-fan commented on a change in pull request #27604:
[SPARK-30849][CORE][SHUFFLE]Fix application failed due to failed to get
MapStatuses broadcast block
URL: https://github.com/apache/spark/pull/27604#discussion_r388343716
##########
File path: core/src/main/scala/org/apache/spark/MapOutputTracker.scala
##########
@@ -824,11 +825,15 @@ private[spark] class MapOutputTrackerWorker(conf:
SparkConf) extends MapOutputTr
endPartition: Int): Iterator[(BlockManagerId, Seq[(BlockId, Long,
Int)])] = {
logDebug(s"Fetching outputs for shuffle $shuffleId, mappers
$startMapIndex-$endMapIndex" +
s"partitions $startPartition-$endPartition")
- val statuses = getStatuses(shuffleId, conf)
try {
+ val statuses = getStatuses(shuffleId, conf)
MapOutputTracker.convertMapStatuses(
shuffleId, startPartition, endPartition, statuses, startMapIndex,
endMapIndex)
} catch {
+ case e: IOException if
+
Throwables.getCausalChain(e).asScala.exists(_.isInstanceOf[BlockNotFoundException])
=>
+ mapStatuses.clear()
Review comment:
It looks more consistent to me to throw `MetadataFetchFailedException` in
`getStatuses`. Then we can reuse the handling of `MetadataFetchFailedException`
below.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
