Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/4826#issuecomment-76538036
@yhuai @liancheng I have no much to say. As you already opened these new
prs that do what I submitted before in #4729, I closed the pr
Although you have explained why you did this, looks like you are not doing
what you meant. You said you would not use my proposed approach, but then you
create this to use it.
Maybe you should read these articles for pr etiquette.
http://readwrite.com/2014/07/02/github-pull-request-etiquette
http://www.quora.com/GitHub/Is-it-bad-etiquette-to-change-someones-pull-request-before-committing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
