clarkead commented on a change in pull request #27370: [SPARK-30654][WebUI]
Bootstrap4 WebUI upgrade
URL: https://github.com/apache/spark/pull/27370#discussion_r386751388
##########
File path: core/src/main/resources/org/apache/spark/ui/static/executorspage.js
##########
@@ -562,10 +562,10 @@ $(document).ready(function () {
$("#showAdditionalMetrics").append(
"<div><a id='additionalMetrics'>" +
- "<span class='expand-input-rate-arrow arrow-closed'
id='arrowtoggle-optional-metrics'></span>" +
+ "<span class='expand-input-rate-arrow arrow-closed'
id='arrowtoggle-optional-metrics'></span> " +
Review comment:
The space was removed. It was originally added to make the arrow spacing
consistent between the executor page and the other pages since the other pages
rely on whitespace for the gap between the arrow and the expand / collapse
text. Fixing all other occurrences would require many more code changes so I
just reverted the space for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
