dbtsai commented on a change in pull request #27814: [SPARK-31058] [SQL]
[test-hive1.2] Consolidate the implementation of `quoteIfNeeded`
URL: https://github.com/apache/spark/pull/27814#discussion_r388599475
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/CatalogV2Implicits.scala
##########
@@ -122,10 +122,10 @@ private[sql] object CatalogV2Implicits {
s"$quoted is not a valid TableIdentifier as it has more than 2 name
parts.")
}
- def quoted: String = parts.map(quote).mkString(".")
+ def quoted: String = parts.map(quoteIfNeeded).mkString(".")
}
- def quote(part: String): String = {
+ def quoteIfNeeded(part: String): String = {
Review comment:
We should.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
