cloud-fan commented on a change in pull request #27643: [SPARK-30886][SQL]
Deprecate two-parameter TRIM/LTRIM/RTRIM functions
URL: https://github.com/apache/spark/pull/27643#discussion_r388699173
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala
##########
@@ -768,4 +769,54 @@ class AnalysisSuite extends AnalysisTest with Matchers {
assert(message.startsWith(s"Max iterations ($maxIterations) reached for
batch Resolution, " +
s"please set '${SQLConf.ANALYZER_MAX_ITERATIONS.key}' to a larger
value."))
}
+
+ test("SPARK-30886 Deprecate two-parameter TRIM/LTRIM/RTRIM") {
+ Seq("trim", "ltrim", "rtrim").foreach { f =>
+ val logAppender = new LogAppender("deprecated two-parameter
TRIM/LTRIM/RTRIM functions")
+ def check(count: Int, message: String): Unit = {
Review comment:
the `message` is always the same, do we need this parameter?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
