Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/4838#discussion_r25563255
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -1074,7 +1074,7 @@ private[spark] class BlockManager(
* Remove all blocks belonging to the given broadcast.
*/
def removeBroadcast(broadcastId: Long, tellMaster: Boolean): Int = {
- logInfo(s"Removing broadcast $broadcastId")
--- End diff --
It would be good to make sure that when the user explicitly `destroy()`s a
broadcast, we do have some INFO level logging that we are doing it. I think
that can be achieved by dropping this one to debug and logging things higher up
in the call stack in the destroy method of either broadcast implementation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
