MaxGekk commented on a change in pull request #27807: [SPARK-31076][SQL]
Convert Catalyst's DATE/TIMESTAMP to Java Date/Timestamp via local date-time
URL: https://github.com/apache/spark/pull/27807#discussion_r389125025
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/HiveResultSuite.scala
##########
@@ -23,7 +23,7 @@ class HiveResultSuite extends SharedSparkSession {
import testImplicits._
test("date formatting in hive result") {
- val dates = Seq("2018-12-28", "1582-10-13", "1582-10-14", "1582-10-15")
+ val dates = Seq("2018-12-28", "1581-10-13", "1581-10-14", "1581-10-15")
Review comment:
Converting dates between 1582-10-04 and 1582-10-15 seems ambiguous, and
depends on the implementation. I changed to the dates to have more
deterministic behavior.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
