rdblue commented on a change in pull request #27838:
[SPARK-30902][SQL][FOLLOW-UP] Allow ReplaceTableAsStatement to have none
provider
URL: https://github.com/apache/spark/pull/27838#discussion_r389182195
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala
##########
@@ -305,7 +305,8 @@ class ResolveSessionCatalog(
// session catalog and the table provider is not v2.
case c @ ReplaceTableStatement(
SessionCatalogAndTable(catalog, tbl), _, _, _, _, _, _, _, _, _) =>
- if (!isV2Provider(c.provider)) {
+ val provider = c.provider.getOrElse(conf.defaultDataSourceName)
Review comment:
I think this should not use Spark's default. The default provider should be
determined by the catalog, not by Spark. For example, if my default provider is
`parquet` then how should a JDBC catalog interpret this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
