chrysan commented on a change in pull request #27831: [SPARK-31069][CORE] high
cpu caused by chunksBeingTransferred in external shuffle service
URL: https://github.com/apache/spark/pull/27831#discussion_r389239180
##########
File path:
common/network-common/src/main/java/org/apache/spark/network/server/OneForOneStreamManager.java
##########
@@ -192,11 +196,7 @@ public void streamSent(String streamId) {
@Override
public long chunksBeingTransferred() {
- long sum = 0L;
- for (StreamState streamState: streams.values()) {
- sum += streamState.chunksBeingTransferred.get();
- }
Review comment:
It makes no big different if the shuffle server handles not many chunks.
While in our production environment, we found when the number of chunks reach
100,000 or more, sometimes most of the cpu resource are occupied by iterating
and calculation the total number. Then no cpu resource to handle request and
response data, which makes everything stuck.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
