srowen commented on issue #27841: [SPARK-31077][ML] Remove ChiSqSelector dependency on mllib.ChiSqSelectorModel URL: https://github.com/apache/spark/pull/27841#issuecomment-596125450 Up to you how you want to proceed. OK so in the end this should increase code sharing; it's not separating the implementations by copying. p values do sound useful in the model; up to you. Yes it just needs to be backwards-compatible.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
