Eric5553 commented on a change in pull request #27846: [SPARK-31079][SQL]
Logging QueryExecutionMetering in RuleExecutor logger
URL: https://github.com/apache/spark/pull/27846#discussion_r389543359
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/OptimizerLoggingSuite.scala
##########
@@ -49,12 +49,19 @@ class OptimizerLoggingSuite extends PlanTest {
case event => Seq(
"Applying Rule",
"Result of Batch",
- "has no effect").exists(event.getRenderedMessage().contains)
+ "has no effect",
+ "Metrics of Executed
Rules").exists(event.getRenderedMessage().contains)
Review comment:
The metrics will be reported at `RuleExecutor.execute` level. I double
checked the code and found I logged it at the wrong place within
`batches.foreach` loop. Fixed it by abc864ef7e41d65932060436331a57db8d77fbe7.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
