Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/4828#discussion_r25582237
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/ui/StreamingPage.scala ---
@@ -20,20 +20,26 @@ package org.apache.spark.streaming.ui
import java.util.Calendar
import javax.servlet.http.HttpServletRequest
-import scala.xml.Node
-
import org.apache.spark.Logging
-import org.apache.spark.ui._
import org.apache.spark.ui.UIUtils._
+import org.apache.spark.ui._
import org.apache.spark.util.Distribution
+import scala.xml.Node
+
/** Page for Spark Web UI that shows statistics of a streaming job */
private[ui] class StreamingPage(parent: StreamingTab)
extends WebUIPage("") with Logging {
- private val listener = parent.listener
- private val startTime = Calendar.getInstance().getTime()
+ private var listener = parent.listener
+ private var startTime = Calendar.getInstance().getTime()
private val emptyCell = "-"
+
+ def updateListener(listener : StreamingJobProgressListener):
+ Unit ={
--- End diff --
The wrapping is wrong here; `Unit` should be on the previous line and no
space before the brace. No space before `:`. Also, `System.currentTimeMillis()`
is much more conventional for getting the time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
