tgravescs commented on a change in pull request #27636: [SPARK-30873][CORE][YARN]Handling Node Decommissioning for Yarn cluster manger in Spark URL: https://github.com/apache/spark/pull/27636#discussion_r389755910
########## File path: core/src/main/scala/org/apache/spark/scheduler/cluster/ClusterInfo.scala ########## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.scheduler.cluster + +import java.text.SimpleDateFormat + +import scala.collection.mutable.{HashMap} + +import org.apache.hadoop.yarn.api.records.{NodeState => YarnNodeState} + +/** + * State of the node. + * Add the node state depending upon the cluster manager, For Yarn + * getYarnNodeState is added to create the node state for Decommission Tracker + */ +private[spark] object NodeState extends Enumeration { + val RUNNING, DECOMMISSIONED, GRACEFUL_DECOMMISSIONING, DECOMMISSIONING, LOST, OTHER = Value Review comment: I wonder the same thing. We have an executor monitor, this is for node state, but I wonder if they shouldn't be linked better. Also why is this file called ClusterInfo? Couldn't there also be other states like terminating. Perhaps we need a node monitor, but not sure if that overlaps to much with the resource-manager pieces. But I'll have to think about it more ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
