yuchenhuo commented on a change in pull request #27838:
[SPARK-30902][SQL][FOLLOW-UP] Allow ReplaceTableAsStatement to have none
provider
URL: https://github.com/apache/spark/pull/27838#discussion_r389934818
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala
##########
@@ -305,7 +305,8 @@ class ResolveSessionCatalog(
// session catalog and the table provider is not v2.
case c @ ReplaceTableStatement(
SessionCatalogAndTable(catalog, tbl), _, _, _, _, _, _, _, _, _) =>
- if (!isV2Provider(c.provider)) {
+ val provider = c.provider.getOrElse(conf.defaultDataSourceName)
Review comment:
Maybe `CatalogPlugin` should expose an interface for the default provider?
It's not so clear to me what's the relationship between provider and catalog.
Should every catalog have a provider?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
