Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4847#discussion_r25584861
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrame.scala ---
    @@ -337,11 +337,11 @@ class DataFrame protected[sql](
        * {{{
        *   // Scala:
        *   import org.apache.spark.sql.functions._
    -   *   df1.join(df2, "outer", $"df1Key" === $"df2Key")
    +   *   df1.join(df2, $"df1Key" === $"df2Key", "outer")
        *
        *   // Java:
        *   import static org.apache.spark.sql.functions.*;
    -   *   df1.join(df2, "outer", col("df1Key") === col("df2Key"));
    +   *   df1.join(df2, col("df1Key") === col("df2Key"), "outer");
    --- End diff --
    
    actually while you are at it, do you mind fixing the java example? it 
definitely wouldn't work with col("df1key") === col("df2key").
    
    I think you need col("df1Key").equalTo(col("df2Key"))


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to