HeartSaVioR opened a new pull request #27860: [SPARK-31101][SQL][BUILD] Upgrade 
Janino to 3.1.1
URL: https://github.com/apache/spark/pull/27860
 
 
   ### What changes were proposed in this pull request?
   
   This PR proposes to upgrade Janino to 3.1.1 which is released recently.
   
   Major changes were done for refactoring, as well as there're lots of "no 
commit message". Belows are the pairs of (commit title, commit) which seem to 
deal with some bugs or specific improvements.
   
   * issue #107: Janino requires "org.codehaus.commons.compiler.io", but 
commons-compiler does not export this package
     * 
https://github.com/janino-compiler/janino/commit/f7d99596d43c56ab7b65cc8117db93f0fe4c6b6b
   * Throw an NYI CompileException when a static interface method is invoked.
     * 
https://github.com/janino-compiler/janino/commit/efd3884983479f6e97adc2a270d02550276b7d3c
   * Fixed the promotion of the array access index expression (see JLS7 15.13 
Array Access Expressions)
     * 
https://github.com/janino-compiler/janino/commit/32fdb5f5f199c819394cae769e47d6fdcfa06b8f
   * Issue #104: ClassLoaderIClassLoader 's ClassNotFoundException handle 
mechanism enhancement
     * 
https://github.com/janino-compiler/janino/commit/6e8a97d60908ecfa08b1d2d7c428a2631300516b
   
   ### Why are the changes needed?
   
   We got some report on failure on user's query which Janino throws error on 
compiling generated code. The issue is here: 
https://github.com/janino-compiler/janino/issues/113 
   It contains the information of generated code, symptom (error), and analysis 
of the bug, so please refer the link for more details.
   Janino 3.1.1 contains the fix 
https://github.com/janino-compiler/janino/pull/114 which would enable user's 
query to run again.
   
   Furthermore, from my testing, 
https://github.com/janino-compiler/janino/issues/90 (which Josh Rosen filed 
before) seems to be also resolved in 3.1.1 as well.
   
   Looks like Janino is maintained by one person and there's no even version 
branches and releases/tags so we can't expect Janino maintainer to release a 
new bugfix version - hence have to try out new minor version.
   
   ### Does this PR introduce any user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   Existing UTs.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to