Ngone51 commented on a change in pull request #27855: [SPARK-31093][SHUFFLE]
Fast fail while fetching shuffle data unsuccessfully
URL: https://github.com/apache/spark/pull/27855#discussion_r390076374
##########
File path:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
##########
@@ -625,6 +636,10 @@ final class ShuffleBlockFetcherIterator(
result match {
case r @ SuccessFetchResult(blockId, mapIndex, address, size, buf,
isNetworkReqDone) =>
+ failureFetchResult.foreach { ffr =>
+ buf.release()
+ throwFetchFailedException(ffr.blockId, ffr.mapIndex, ffr.address,
ffr.e)
Review comment:
errr...I just feel that this makes things be more complex... I actually
think that *fail-fast* here is not such necessary unless we really have high
delay in current way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
