Ngone51 commented on a change in pull request #27849: [SPARK-31081][UI][SQL]
Make metrics in SparkPlanGraphNode more readable from Spark UI
URL: https://github.com/apache/spark/pull/27849#discussion_r390127370
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/metric/SQLMetrics.scala
##########
@@ -126,16 +125,14 @@ object SQLMetrics {
// duration(min, med, max):
// 5s (800ms, 1s, 2s)
val acc = new SQLMetric(TIMING_METRIC, -1)
- acc.register(sc, name = Some(s"$name total (min, med, max (stageId
(attemptId): taskId))"),
- countFailedValues = false)
+ acc.register(sc, name = Some(name), countFailedValues = false)
acc
}
def createNanoTimingMetric(sc: SparkContext, name: String): SQLMetric = {
// Same with createTimingMetric, just normalize the unit of time to
millisecond.
val acc = new SQLMetric(NS_TIMING_METRIC, -1)
- acc.register(sc, name = Some(s"$name total (min, med, max (stageId
(attemptId): taskId))"),
- countFailedValues = false)
+ acc.register(sc, name = Some(s"name"), countFailedValues = false)
Review comment:
TODO: fix "name"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
