Ngone51 commented on a change in pull request #27604:
[SPARK-30849][CORE][SHUFFLE]Fix application failed due to failed to get
MapStatuses broadcast block
URL: https://github.com/apache/spark/pull/27604#discussion_r390191608
##########
File path: core/src/main/scala/org/apache/spark/MapOutputTracker.scala
##########
@@ -851,8 +852,16 @@ private[spark] class MapOutputTrackerWorker(conf:
SparkConf) extends MapOutputTr
var fetchedStatuses = mapStatuses.get(shuffleId).orNull
if (fetchedStatuses == null) {
logInfo("Doing the fetch; tracker endpoint = " + trackerEndpoint)
- val fetchedBytes =
askTracker[Array[Byte]](GetMapOutputStatuses(shuffleId))
- fetchedStatuses =
MapOutputTracker.deserializeMapStatuses(fetchedBytes, conf)
+ try {
+ val fetchedBytes =
askTracker[Array[Byte]](GetMapOutputStatuses(shuffleId))
+ fetchedStatuses =
MapOutputTracker.deserializeMapStatuses(fetchedBytes, conf)
+ } catch {
+ case e: IOException if
+
Throwables.getCausalChain(e).asScala.exists(_.isInstanceOf[BlockNotFoundException])
=>
+ mapStatuses.clear()
Review comment:
I think there's a potential assuming that *shuffle data aways randomly and
evenly placed on nodes*. That means, any shuffle fetch failure can imply the
potential fetch failure for other shuffles in future. So, currently, we aways
clear `mapStatuses` when fetch failure happens.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
