dbtsai commented on a change in pull request #27817: [SPARK-31060][SQL] Handle
column names containing `dots` in data source `Filter`
URL: https://github.com/apache/spark/pull/27817#discussion_r390487702
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
##########
@@ -652,10 +652,11 @@ object DataSourceStrategy {
*/
object PushableColumn {
def unapply(e: Expression): Option[String] = {
+ import org.apache.spark.sql.connector.catalog.CatalogV2Implicits._
def helper(e: Expression) = e match {
case a: Attribute => Some(a.name)
case _ => None
}
- helper(e)
+ helper(e).map(quoteIfNeeded)
Review comment:
@HyukjinKwon You are right. I'm just breaking
https://github.com/apache/spark/pull/27780 into smaller PR so it's easier to
review. Chat with @cloud-fan offline, and I'll close this one and work on the
other bigger one to avoid the confusion. Let's discuss how we want to handle
the API compatibility in the other PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
