Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/4789#discussion_r25639164
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala
---
@@ -467,6 +467,7 @@ class HiveQuerySuite extends HiveComparisonTest with
BeforeAndAfter {
test("sampling") {
sql("SELECT * FROM src TABLESAMPLE(0.1 PERCENT) s")
+ sql("SELECT * FROM src TABLESAMPLE(100 PERCENT) s")
--- End diff --
I'm going to go ahead and merge this since it changes semantics and we are
close to the release where we remove the alpha tag, but it would be great if
you could add a test that actually checks to make sure sampling is happening
and we are getting something close to the expected number of results.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
