skambha commented on issue #27627: [WIP][SPARK-28067][SQL] Fix incorrect results for decimal aggregate sum by returning null on decimal overflow URL: https://github.com/apache/spark/pull/27627#issuecomment-597997273 >How about we add a new expression DecimalSum? Sure we can do that, if that is the preferred approach. I'll look into it IIUC, you are proposing that we add a new DecimalSum aggregate function and this would be just for input type decimal. Is the expectation that the user would now call this from their queries for their decimal sum operations? If so, how would we like to handle the issue when user uses sum for their decimal columns. -- >4. the mergeExpression should do: Won't we also need to check for overflow in here as well. for e.g sum.left and sum.right are added. None of them overflowed when doing the update expressions, but when you add them during the merge the combined value overflows. Thanks @cloud-fan
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
