Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/4857#discussion_r25641946
--- Diff:
core/src/main/scala/org/apache/spark/network/netty/NettyBlockRpcServer.scala ---
@@ -63,11 +83,83 @@ class NettyBlockRpcServer(
// StorageLevel is serialized as bytes using our JavaSerializer.
val level: StorageLevel =
serializer.newInstance().deserialize(ByteBuffer.wrap(uploadBlock.metadata))
- val data = new
NioManagedBuffer(ByteBuffer.wrap(uploadBlock.blockData))
+ val data = new
NioManagedBuffer(LargeByteBufferHelper.asLargeByteBuffer(uploadBlock.blockData))
+ logTrace("putting block into our block manager: " + blockManager)
blockManager.putBlockData(BlockId(uploadBlock.blockId), data,
level)
responseContext.onSuccess(new Array[Byte](0))
+
+ case uploadPartialBock: UploadPartialBlock =>
+ logTrace("received upload partial block: " + uploadPartialBock)
--- End diff --
This is a key component of block replication for blocks > 2gb. Definitely
need feedback on how robust this approach is, if the handling of dropped
messages is sane, etc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
