cloud-fan commented on issue #27627: [WIP][SPARK-28067][SQL] Fix incorrect 
results for decimal aggregate sum by returning null on decimal overflow
URL: https://github.com/apache/spark/pull/27627#issuecomment-598002388
 
 
   > Is the expectation that the user would now call this from their queries 
for their decimal sum operations?
   
   No, it's just a new expression. Analyzer is responsible for converting `Sum` 
with decimal type input to `DecimalSum`.
   
   > Won't we also need to check for overflow in here as well.
   
   ah yes, thanks for catching it!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to