zhengruifeng commented on a change in pull request #27882: [SPARK-31127][ML]
Add abstract Selector
URL: https://github.com/apache/spark/pull/27882#discussion_r391396309
##########
File path: mllib/src/main/scala/org/apache/spark/ml/feature/ChiSqSelector.scala
##########
@@ -266,72 +134,27 @@ object ChiSqSelector extends
DefaultParamsReadable[ChiSqSelector] {
@Since("1.6.0")
final class ChiSqSelectorModel private[ml] (
@Since("1.6.0") override val uid: String,
- @Since("3.1.0") val selectedFeatures: Array[Int])
- extends Model[ChiSqSelectorModel] with ChiSqSelectorParams with MLWritable {
+ @Since("3.1.0") override val selectedFeatures: Array[Int],
+ @Since("3.1.0") override val pValues: Array[Double],
+ @Since("3.1.0")override val statistic: Array[Double])
Review comment:
nit: space before `override`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
