nchammas opened a new pull request #27910: [SPARK-31153][BUILD] Cleanup several failures in lint-python URL: https://github.com/apache/spark/pull/27910 ### What changes were proposed in this pull request? This PR cleans up several failures -- most of them silent -- in lint-python. I don't understand how we haven't bitten by these yet. Perhaps we've been lucky? Fixes include: * Fix how we compare versions. All the version checks currently in `master` silently fail with: ``` File "<string>", line 2 print(LooseVersion("""2.3.1""") >= LooseVersion("""2.4.0""")) ^ IndentationError: unexpected indent ``` Another problem is that `distutils.version` is undocumented and unsupported. * Fix some basic bugs. e.g. We have an incorrect reference to `$PYDOCSTYLEBUILD`, which doesn't exist, which was causing the doc style test to silently fail with: ``` ./dev/lint-python: line 193: --version: command not found ``` * Stop suppressing error output! It's hiding problems and serves no purpose here. ### Why are the changes needed? lint-python is part of our CI build and is currently doing any combination of the following: silently failing, incorrectly skipping tests, and/or incorrectly downloading libraries when a suitable library is already available. ### Does this PR introduce any user-facing change? No. ### How was this patch tested? Lots of manual testing with `set -x` enabled.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
