nchammas commented on a change in pull request #27912: [SPARK-31155] Enable pydocstyle tests URL: https://github.com/apache/spark/pull/27912#discussion_r392620161
########## File path: dev/tox.ini ########## @@ -18,4 +18,4 @@ ignore=E226,E241,E305,E402,E722,E731,E741,W503,W504 max-line-length=100 exclude=cloudpickle.py,heapq3.py,shared.py,python/docs/conf.py,work/*/*.py,python/.eggs/*,dist/*,.git/* [pydocstyle] -ignore=D100,D101,D102,D103,D104,D105,D106,D107,D200,D201,D202,D203,D204,D205,D206,D207,D208,D209,D210,D211,D212,D213,D214,D215,D300,D301,D302,D400,D401,D402,D403,D404,D405,D406,D407,D408,D409,D410,D411,D412,D413,D414 +ignore=D100,D101,D102,D103,D104,D105,D106,D107,D200,D201,D202,D203,D204,D205,D206,D207,D208,D209,D210,D211,D212,D213,D214,D215,D300,D301,D302,D400,D401,D402,D403,D404,D405,D406,D407,D408,D409,D410,D411,D412,D413,D414,D415,D416,D417 Review comment: Yep, totally disabled on both Jenkins and GitHub. I think it was unintentional, because `lint-python` accepts when pydocstyle is missing and just happily carries along. I'm honestly skeptical, given the lengthy list of ignore codes, that we are checking _anything_ with pydocstyle at the moment, even with this fix. In fact, looking at the [reference list of error codes](http://www.pydocstyle.org/en/5.0.2/error_codes.html), I believe that's the case! @shaneknapp / @HyukjinKwon - Are you aware that we haven't been running pydocstyle tests for some time now? Was it intentionally disabled at some point? Even with this PR re-enabling it, I believe we are not actually testing anything, because we've configured the tool to ignore every error it checks for. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
