HyukjinKwon commented on a change in pull request #27901: [SPARK-31146][SQL]
Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#discussion_r392640047
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
##########
@@ -590,7 +590,9 @@ object FunctionRegistry {
if (varargCtor.isDefined) {
// If there is an apply method that accepts Seq[Expression], use that
one.
try {
- varargCtor.get.newInstance(expressions).asInstanceOf[Expression]
+ val exp =
varargCtor.get.newInstance(expressions).asInstanceOf[Expression]
+ if (setAlias) exp.setTagValue(FUNC_ALIAS, name)
Review comment:
Hm, I think it's okay. Even if so, logically the alias should have the
correct name so I would like to treat it as unavoidable even if it brings some
more memory usage.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
