maropu commented on a change in pull request #27897: [SPARK-31113][SQL] Add
SHOW VIEWS command
URL: https://github.com/apache/spark/pull/27897#discussion_r392728591
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/InMemoryCatalog.scala
##########
@@ -346,6 +346,13 @@ class InMemoryCatalog(
StringUtils.filterPattern(listTables(db), pattern)
}
+ override def listViews(db: String, pattern: String): Seq[String] =
synchronized {
+ requireDbExists(db)
+ val views = catalog(db).tables.filter(_._2.table.tableType ==
CatalogTableType.VIEW)
+ .keySet.toSeq.sorted
+ StringUtils.filterPattern(views, pattern)
Review comment:
nit style: to avoid the line break, how about the format below?;
```
val views = catalog(db).tables.filter(_._2.table.tableType ==
CatalogTableType.VIEW).keySet
StringUtils.filterPattern(views.toSeq.sorted, pattern)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
