zhengruifeng commented on a change in pull request #27922:
[SPARK-30776][ML][FOLLOWUP] FValue clean up
URL: https://github.com/apache/spark/pull/27922#discussion_r392797752
##########
File path:
mllib/src/test/scala/org/apache/spark/ml/feature/FValueSelectorSuite.scala
##########
@@ -127,21 +127,18 @@ class FValueSelectorSuite extends MLTest with
DefaultReadWriteTest {
test("Test FValue selector: numTopFeatures") {
val selector = new FValueSelector()
.setOutputCol("filtered").setSelectorType("numTopFeatures").setNumTopFeatures(1)
- val model = selector.fit(dataset)
Review comment:
`model` here is never used, and a model will be fitted in following
`testSelector`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
