Github user davies commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4863#discussion_r25667368
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/mllib/evaluation/BinaryClassificationMetrics.scala
 ---
    @@ -53,6 +54,13 @@ class BinaryClassificationMetrics(
        */
       def this(scoreAndLabels: RDD[(Double, Double)]) = this(scoreAndLabels, 0)
     
    +  /**
    +   * An auxiliary constructor taking a DataFrame.
    +   * @param scoreAndLabels a DataFrame with two double columns: score and 
label
    +   */
    +  private[mllib] def this(scoreAndLabels: DataFrame) =
    +    this(scoreAndLabels.map(r => (r.getDouble(0), r.getDouble(1))))
    --- End diff --
    
    Right now, we use RDD[Python tuple] -> RDD[Row] -> RDD[(Double, Double)], 
I'm saying that we could use RDD[Python tuple] -> RDD[Vector] -> RDD[(Double, 
Double)]


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to