dongjoon-hyun commented on a change in pull request #27888: [SPARK-31116][SQL]
Fix nested schema case-sensitivity in ParquetRowConverter
URL: https://github.com/apache/spark/pull/27888#discussion_r392844105
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetRowConverter.scala
##########
@@ -178,8 +179,17 @@ private[parquet] class ParquetRowConverter(
// Converters for each field.
private[this] val fieldConverters: Array[Converter with
HasParentContainerUpdater] = {
+ val catalystFieldNameToIndex = if (caseSensitive) {
+ catalystType.fieldNames.zipWithIndex.toMap
+ } else {
+ CaseInsensitiveMap(catalystType.fieldNames.zipWithIndex.toMap)
+ }
parquetType.getFields.asScala.map { parquetField =>
- val fieldIndex = catalystType.fieldIndex(parquetField.getName)
+ val fieldIndex = catalystFieldNameToIndex.getOrElse(parquetField.getName,
+ throw new IllegalArgumentException(
Review comment:
It seems that we cannot avoid a runtime exception here. BTW, although I
understand that this follows the existing `IllegalArgumentException` from
`org.apache.spark.sql.types.StructType`, `RuntimeException` might be better in
this context like the other exceptions in this class. (cc @cloud-fan )
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
