cloud-fan commented on a change in pull request #27891: [SPARK-31133][SQL][DOC] 
fix sql ref doc for DML
URL: https://github.com/apache/spark/pull/27891#discussion_r392877044
 
 

 ##########
 File path: docs/sql-ref-syntax-dml-insert-overwrite-directory.md
 ##########
 @@ -39,13 +39,13 @@ INSERT OVERWRITE [ LOCAL ] DIRECTORY [ directory_path ]
 <dl>
   <dt><code><em>file_format</em></code></dt>
   <dd>
-  Specifies the file format to use for the insert. Valid options are 
<code>TEXT</code>, <code>CSV</code>, <code>JSON</code>, <code>JDBC</code>, 
<code>PARQUET</code>, <code>ORC</code>, <code>HIVE</code>, <code>DELTA</code>, 
<code>LIBSVM</code>, or a fully qualified class name of a custom implementation 
of <code>org.apache.spark.sql.sources.DataSourceRegister</code>.
+  Specifies the file format to use for the insert. Valid options are 
<code>TEXT</code>, <code>CSV</code>, <code>JSON</code>, <code>JDBC</code>, 
<code>PARQUET</code>, <code>ORC</code>, <code>HIVE</code>, <code>DELTA</code>, 
<code>LIBSVM</code>, or a fully qualified class name of a custom implementation 
of <code>org.apache.spark.sql.execution.datasources.FileFormat</code>.
 
 Review comment:
   Avro implements `FileFormat`. I don't know if DELTA is supported in `INSERT 
OVERWRITE [ LOCAL ] DIRECTORY`, let me remove it as it's an external source.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to