cloud-fan commented on a change in pull request #27906: [SPARK-31150][SQL]
Parsing seconds fraction with variable length for timestamp
URL: https://github.com/apache/spark/pull/27906#discussion_r392909949
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeFormatterHelper.scala
##########
@@ -51,12 +51,17 @@ trait DateTimeFormatterHelper {
// In this way, synchronised is intentionally omitted in this method to make
parallel calls
// less synchronised.
// The Cache.get method is not used here to avoid creation of additional
instances of Callable.
- protected def getOrCreateFormatter(pattern: String, locale: Locale):
DateTimeFormatter = {
+ protected def getOrCreateFormatter(
+ pattern: String,
+ locale: Locale,
+ varLenEnabled: Boolean = false): DateTimeFormatter = {
Review comment:
let's make the name more explicit: `isParsing`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
