Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4848#discussion_r25671346
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala 
---
    @@ -774,7 +778,7 @@ private[spark] class Master(
           case fnf: FileNotFoundException =>
             // Event logging is enabled for this application, but no event 
logs are found
             val title = s"Application history not found (${app.id})"
    -        var msg = s"No event logs found for application $appName in 
${app.desc.eventLogDir}."
    +        var msg = s"No event logs found for application $appName in 
${app.desc.eventLogDir.get}."
    --- End diff --
    
    the `.get` is a minor unrelated change, right?
    
    I think this looks good in that it changes a situation where Spark does 
nothing and just shows an error, into one where it shows something, which may 
be needed for debugging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to