Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/532#issuecomment-41305384
Hey, thanks for this fix too! I'm a little torn about adding the
nullability, foldability and datatype checks to all the evaluation tests. At
the very least, we need to use named parameters with Boolean arguments to keep
things readable. However, I think a better option might be to separate these
checks out into their own unit tests. Doing so might decease the amount of
redundancy and make it more obvious what cases are actually being tested.
Mostly I want to keep a very concise way to write expression evaluation unit
tests so that it is easy to keep adding them. What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
