cloud-fan commented on a change in pull request #27906: [SPARK-31150][SQL] Parsing seconds fraction with variable length for timestamp URL: https://github.com/apache/spark/pull/27906#discussion_r393157717
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/TimestampFormatter.scala ########## @@ -95,7 +97,8 @@ class Iso8601TimestampFormatter( * @param zoneId the time zone identifier in which the formatter parses or format timestamps */ class FractionTimestampFormatter(zoneId: ZoneId) Review comment: Now I'm wondering if `isParsing` is a good name. Here we do formatting, but we want to use var-length second fraction to avoid padding `0` at the end. How about renaming to `needVarLengthSecondFraction`? We can use `false` as the default value then many tests do not need to be changed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
