cloud-fan commented on a change in pull request #27906: [SPARK-31150][SQL]
Parsing seconds fraction with variable length for timestamp
URL: https://github.com/apache/spark/pull/27906#discussion_r393187954
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeFormatterHelper.scala
##########
@@ -104,8 +111,40 @@ private object DateTimeFormatterHelper {
.withResolverStyle(ResolverStyle.STRICT)
}
- def buildFormatter(pattern: String, locale: Locale): DateTimeFormatter = {
- val builder = createBuilder().appendPattern(pattern)
+ /**
+ * Building a formatter for parsing seconds fraction with variable length
+ */
+ def createBuilderWithVarLengthSecondFraction(
+ pattern: String,
+ builder: DateTimeFormatterBuilder): DateTimeFormatterBuilder = {
Review comment:
nit: do we need this parameter? I think it's safer to create a fresh builder
inside this method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
