Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/35#discussion_r11959364
--- Diff:
core/src/main/scala/org/apache/spark/deploy/worker/ExecutorRunner.scala ---
@@ -58,30 +58,27 @@ private[spark] class ExecutorRunner(
override def run() { fetchAndRunExecutor() }
}
workerThread.start()
-
// Shutdown hook that kills actors on shutdown.
shutdownHook = new Thread() {
override def run() {
- if (process != null) {
- logInfo("Shutdown hook killing child process.")
- process.destroy()
- process.waitFor()
- }
+ killProcess()
}
}
Runtime.getRuntime.addShutdownHook(shutdownHook)
}
+ private def killProcess() {
+ logInfo("Killing process!")
--- End diff --
I think we still should have the null check (just not null set) since
process starts out null, like in the prior shutdown hook.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
