yaooqinn commented on a change in pull request #27906: [SPARK-31150][SQL]
Parsing seconds fraction with variable length for timestamp
URL: https://github.com/apache/spark/pull/27906#discussion_r393457826
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/util/TimestampFormatterSuite.scala
##########
@@ -235,7 +237,7 @@ class TimestampFormatterSuite extends SparkFunSuite with
SQLHelper with Matchers
}
test("SPARK-30958: parse timestamp with negative year") {
- val formatter1 = TimestampFormatter("yyyy-MM-dd HH:mm:ss", ZoneOffset.UTC)
+ val formatter1 = TimestampFormatter("yyyy-MM-dd HH:mm:ss", ZoneOffset.UTC,
true)
Review comment:
yes, the actual parser should work with patterns w/o SSS too. I don't add
new tests in TimestampFormatterSuite but modify the existing ones because we
have e2e enough tests in `date_time.sql`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
