Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4877#discussion_r25722448
  
    --- Diff: 
core/src/test/scala/org/apache/spark/serializer/KryoSerializerSuite.scala ---
    @@ -23,8 +23,10 @@ import scala.reflect.ClassTag
     import com.esotericsoftware.kryo.Kryo
     import org.scalatest.FunSuite
     
    -import org.apache.spark.{SparkConf, SharedSparkContext}
    +import org.apache.spark.scheduler.HighlyCompressedMapStatus
     import org.apache.spark.serializer.KryoTest._
    +import org.apache.spark.storage.BlockManagerId
    +import org.apache.spark.{SharedSparkContext, SparkConf}
    --- End diff --
    
    @squito For this one I think it is fine to merge, but for future ones, this 
line should go above all other subpackages. We do have some violations of them 
in the codebase, but that's the general guideline.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to