mengxr commented on a change in pull request #27546: [SPARK-30773][ML]Support
NativeBlas for level-1 routines
URL: https://github.com/apache/spark/pull/27546#discussion_r393828874
##########
File path:
mllib-local/src/test/scala/org/apache/spark/ml/linalg/BLASSuite.scala
##########
@@ -23,6 +23,15 @@ import org.apache.spark.ml.util.TestingUtils._
class BLASSuite extends SparkMLFunSuite {
+ test("nativeL1Threshold") {
+ var vectorSize = 128
+ assert(getBLAS(vectorSize) == BLAS.f2jBLAS)
Review comment:
minor: you don't need `var`. just `assert(getBLAS(128) == BLAS.f2jBLAS)` is
sufficient and cleaner.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
