dongjoon-hyun commented on a change in pull request #27905:
[SPARK-31125][K8S]Terminating pods have a deletion timestamp but they are not
yet dead.
URL: https://github.com/apache/spark/pull/27905#discussion_r393905501
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsSnapshot.scala
##########
@@ -72,5 +74,8 @@ object ExecutorPodsSnapshot extends Logging {
}
}
- private def isDeleted(pod: Pod): Boolean =
pod.getMetadata.getDeletionTimestamp != null
+ private def isDeleted(pod: Pod): Boolean = {
+ (pod.getMetadata.getDeletionTimestamp != null &&
+ pod.getStatus.getPhase.toLowerCase(Locale.ROOT) != "terminating")
Review comment:
Oops. I missed your comment here. It was in UT failure (instead of K8s IT).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
