Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/4871#issuecomment-77047210
It makes _some_ tiny difference; my observation was that the `stopped`
flag's state can be observed outside this `synchronized` method. So its
interleaving with other operations could matter. I have no idea if it does, but
yeah, seems more logical to not put some operations before the flag state
change. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
