HyukjinKwon commented on a change in pull request #27911: [SPARK-31154][SQL]
Expose basic write metrics for InsertIntoDataSourceCommand
URL: https://github.com/apache/spark/pull/27911#discussion_r394825460
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/sources/interfaces.scala
##########
@@ -292,7 +293,11 @@ trait PrunedFilteredScan {
*/
@Stable
trait InsertableRelation {
- def insert(data: DataFrame, overwrite: Boolean): Unit
+ def insert(data: DataFrame, overwrite: Boolean): Unit = {}
+
+ def insert(data: DataFrame, overwrite: Boolean, metrics: Map[String,
SQLMetric]): Unit = {
Review comment:
The source isn't necessarily related to files. It's a bit odd to assume the
number of files here. Also, seems like this is what DSv2 should cover?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
