HyukjinKwon commented on a change in pull request #27928: [SPARK-31167][BUILD] Refactor how we track Python test/build dependencies URL: https://github.com/apache/spark/pull/27928#discussion_r394842917
########## File path: dev/requirements.txt ########## @@ -1,5 +1,7 @@ -flake8==3.5.0 +pycodestyle==2.5.0 +flake8==3.7.9 jira==1.0.3 PyGithub==1.26.0 Unidecode==0.04.19 -sphinx +sphinx==2.3.1 +numpy==1.18.1 Review comment: There's the trade-off here as well - it's the most stable but there might be multiple bugs existing fixed in the upstream. It will still mess developer's environment. Arguably there are not so many Python-dedicated dev people in Spark community who fluently use pyenv, virtualenv or conda. _I think_ most of them just use pip and local installation. I quickly skimmed requirements.txt **for dev or docs** at [here](https://hackernoon.com/50-popular-python-open-source-projects-on-github-in-2018-c750f9bf56a0). I skimmed top 20 projects, and found 6 instances. - One was completely pinned. - Two were partially pinned - Three were not quite pinned. I agree the dev envs more tend to specify the versions; however, I think it's still prevailing to don't pin. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
