Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4894#discussion_r25806676
  
    --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
    @@ -639,19 +640,22 @@ private[spark] object Utils extends Logging {
           fs: FileSystem,
           conf: SparkConf,
           hadoopConf: Configuration,
    -      fileOverwrite: Boolean): Unit = {
    -    if (!targetDir.mkdir()) {
    +      fileOverwrite: Boolean,
    +      filename: Option[String] = None): Unit = {
    --- End diff --
    
    can we add a comment that says this is only expected to be set if the path 
describes a file, not a directory?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to