cloud-fan commented on a change in pull request #27953: [SPARK-31183][SQL]
Rebase date/timestamp from/to Julian calendar in Avro
URL: https://github.com/apache/spark/pull/27953#discussion_r395453034
##########
File path:
external/avro/src/test/scala/org/apache/spark/sql/avro/AvroLogicalTypeSuite.scala
##########
@@ -348,6 +348,100 @@ abstract class AvroLogicalTypeSuite extends QueryTest
with SharedSparkSession {
assert(msg.contains("Unscaled value too large for precision"))
}
}
+
+ private def readResourceAvroFile(name: String): DataFrame = {
+ val url = Thread.currentThread().getContextClassLoader.getResource(name)
+ spark.read.format("avro").load(url.toString)
+ }
+
+ test("SPARK-31183: compatibility with Spark 2.4 in reading
dates/timestamps") {
Review comment:
missed one thing. I think the test is not very related to logical types and
probably should be put in `AvroSuite`.
@MaxGekk can you move the test in your next PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
