HeartSaVioR commented on a change in pull request #27877: [SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry URL: https://github.com/apache/spark/pull/27877#discussion_r395609658
########## File path: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaTestUtils.scala ########## @@ -74,6 +74,7 @@ class KafkaTestUtils( logInfo(s"Local host name is $localCanonicalHostName") private var kdc: MiniKdc = _ + private var kdcDataDir: File = _ Review comment: consider `createKeytabsAndJaasConfigFile` as setup and `teardown` as cleanup - you'll find the reason. There might be some utility method to do cleanup of temp dir automatically as well. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
