Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3486#discussion_r25830508
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/worker/ExecutorRunner.scala ---
    @@ -134,6 +135,12 @@ private[spark] class ExecutorRunner(
           // In case we are running this from within the Spark Shell, avoid 
creating a "scala"
           // parent process for the executor command
           builder.environment.put("SPARK_LAUNCH_WITH_SCALA", "0")
    +
    +      // Add webUI log urls
    +      val baseUrl = 
s"http://$host:$webUiPort/logPage/?appId=$appId&executorId=$execId&logType=";
    --- End diff --
    
    It looks like `$host` here might be a machine's hostname, but we probably 
want this to reflect SPARK_PUBLIC_DNS (or whatever the new system property 
equivalent is) so that we generate an externally-accessible URL.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to